fix(cypress): wait for ressource load

Signed-off-by: skjnldsv <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud · Sep 14, 2024 · aefe587 · aefe587
1 parent 3b28060
commit aefe587
Show file tree

Hide file tree

Showing 24 changed files with 31 additions and 737 deletions.
diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml
@@ -58,7 +58,7 @@ jobs:
       - name: Install node dependencies & build app
         run: |
           npm ci
-          TESTING=true npm run build --if-present
+          npm run build --if-present
 
       - name: Save context
         uses: buildjet/cache/save@e376f15c6ec6dc595375c78633174c7e5f92dc0e # v3
@@ -112,7 +112,6 @@ jobs:
           # https://github.com/cypress-io/github-action/issues/124
           COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }}
           # Needed for some specific code workarounds
-          TESTING: true
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
           SPLIT: ${{ matrix.total-containers }}

diff --git a/css/viewer-index.css b/css/viewer-index.css
diff --git a/css/viewer-main.css b/css/viewer-main.css
diff --git a/cypress/e2e/visual-regression.cy.ts b/cypress/e2e/visual-regression.cy.ts
@@ -46,6 +46,7 @@ describe('Visual regression tests', function() {
 	})
 
 	it('See files in the list', function() {
+		// TODO: Do we care about the file name being split by a ' ' in the text property?
 		cy.getFile('test-card.mp4', { timeout: 10000 })
 			.should('contain', 'test-card .mp4')
 		cy.getFile('test-card.png', { timeout: 10000 })

diff --git a/js/viewer-filerobot.js b/js/viewer-filerobot.js
diff --git a/js/viewer-filerobot.js.map b/js/viewer-filerobot.js.map
diff --git a/js/viewer-main.js b/js/viewer-main.js