Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment compile step #2069

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 23, 2023

No description provided.

Signed-off-by: Simon L <[email protected]>
@szaimen szaimen added the 3. to review Waiting for reviews label Nov 23, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Nov 23, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Nov 23, 2023

@AndyScherzinger can you force-merge? The CI failure is unrelated

@AndyScherzinger AndyScherzinger merged commit 58fd661 into master Nov 23, 2023
25 of 27 checks passed
@AndyScherzinger AndyScherzinger deleted the enh/noid/audit-fix-comment-comile-step branch November 23, 2023 11:06
@AndyScherzinger
Copy link
Member

@szaimen Done 👍

@szaimen
Copy link
Contributor Author

szaimen commented Nov 23, 2023

Now after https://github.com/nextcloud/viewer/actions/runs/6968873818 it should work...

@AndyScherzinger
Copy link
Member

Action then probably needs to be renamed here, since it doesn't compile anymore. Also since this action comes from the template repo it will get a sync PR overwriting your local changes @szaimen So I think the comments at the top of the action need to be removed. Or the action needs to be made more flexible so compile can be optionally deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants