Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve sort order #2097

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Preserve sort order #2097

merged 1 commit into from
Dec 21, 2023

Conversation

hamza221
Copy link
Contributor

No description provided.

@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews labels Dec 10, 2023
@hamza221 hamza221 requested a review from skjnldsv December 10, 2023 20:21
@hamza221 hamza221 self-assigned this Dec 10, 2023
@skjnldsv
Copy link
Member

Code make sense!

@hamza221
Copy link
Contributor Author

Do you think this will cause a problem if viewer is called from an app other than files?

@skjnldsv
Copy link
Member

Do you think this will cause a problem if viewer is called from an app other than files?

Most of external apps open their own set of files, which are not sorted by Viewer.
The sorting only occurs if you open the Viewer on a single file and Viewer is the one fetching the files from remote.php/dav/user/files/

@hamza221 hamza221 force-pushed the enh/preserve-sort-order branch from 0b3b0e4 to 5f1dfd8 Compare December 12, 2023 19:11
@skjnldsv
Copy link
Member

Rebase ?

Signed-off-by: hamza mahjoubi <[email protected]>
@hamza221 hamza221 force-pushed the enh/preserve-sort-order branch from 5f1dfd8 to a2853c7 Compare December 20, 2023 13:58
@skjnldsv skjnldsv merged commit aca63e5 into master Dec 21, 2023
27 checks passed
@skjnldsv skjnldsv deleted the enh/preserve-sort-order branch December 21, 2023 08:45
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@Jerome-Herbinet
Copy link
Member

Hi, what version(s) of Nextcloud are or have been impacted by this PR ?

@hamza221
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 23, 2024
Copy link

backportbot bot commented Feb 23, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2097/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a2853c71

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2097/stable28

Error: Failed to clone repository: Failed to clone and cache repo: Cloning into '.'...
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 6157 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants