-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aliasing mimes #2099
base: master
Are you sure you want to change the base?
Fix aliasing mimes #2099
Conversation
Signed-off-by: Daniel Raper <[email protected]>
Signed-off-by: Daniel Raper <[email protected]>
Are you sure that it does not break the overrideHandlerId feature? |
@kesselb I'm not too familiar with that feature. It looks like it could break that, but in that case I'm not convinced it was working correctly to start with. The assignments of nextFile and previousFile use this.components[mime] anyway so the initial file you click on would work with the overrideHandlerId function but if you go to the next file, it wouldn't work? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@DaphneMuller this creates other issues, so it's staled until we have proper planning to resolve those issues. |
@skjnldsv My app camerarawpreviews has been broken due to this since at least Nextcloud 24. It would be great to get this merged/resolved soon. If you browse the issues at camerarawpreviews github repo there is a few duplicate issues every now and then about this. |
@ariselseng merging this reverts another bug I am stuck on this, and don't know what to do |
A re-implementation of #1456 as that seems to have been abandoned. This issue mainly affects the use of ariariselseng/camerarawpreviews.
Fixes #1450 and ariselseng/camerarawpreviews#99.
I haven't noticed any regressions when testing this on my local environment and don't see any reason to not change the instantiation of
this.currentFile
to usethis.components[mime]
instead ofhandler.component
. This is the approach already used forthis.nextFile
andthis.previousFile
.This also fixes a regression in Viewer.js, allowing no mimes (only aliases) to be provided to
registerHandler
.