Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(handlers): validate handlers before adding them #2115

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

max-nextcloud
Copy link
Contributor

Fixes #912 as described in #912 (comment).

@max-nextcloud max-nextcloud requested a review from skjnldsv January 2, 2024 20:56
@max-nextcloud
Copy link
Contributor Author

This copies most of the validations from the Viewer.vue. It could also replace those checks or I can move them to a file imported by both.

@max-nextcloud max-nextcloud force-pushed the fix/912-validate-handlers branch from e6b5daf to 04884bd Compare January 2, 2024 21:05
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 3, 2024
@max-nextcloud
Copy link
Contributor Author

/compile amend /

Fixes #912

Signed-off-by: Max <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/912-validate-handlers branch from 04884bd to 12e0091 Compare January 3, 2024 07:40
@max-nextcloud max-nextcloud merged commit 14dcb39 into master Jan 3, 2024
29 checks passed
@max-nextcloud max-nextcloud deleted the fix/912-validate-handlers branch January 3, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid handlers are still listed in OC.Viewer.availableHandlers
2 participants