-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed wrong color on active actions button #2139
fix: removed wrong color on active actions button #2139
Conversation
/backport to stable28 |
/compile amend/ |
66f6d22
to
31164ca
Compare
Moved the changed CSS to another appropriate place that lets it not display the outline 👍 |
50799ae
to
3ac8bea
Compare
Signed-off-by: Eduardo Morales <[email protected]>
3ac8bea
to
c820b3d
Compare
Thanks @emoral435! Force-pushed a small adjustment to remove !important so the hover/focus styles apply correctly |
/compile amend / |
Signed-off-by: Eduardo Morales <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
c820b3d
to
d4166c1
Compare
Thank you @Pytal :) |
This comment was marked as resolved.
This comment was marked as resolved.
/backport f75d877 to stable28 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
☑️ Resolves #2138
🖼️ Screenshots
![firefox_QHrfv5gnmn](https://private-user-images.githubusercontent.com/110193237/300671597-a20b4ab0-b92e-47f7-93ab-fa874e774108.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4ODc3MDcsIm5iZiI6MTczODg4NzQwNywicGF0aCI6Ii8xMTAxOTMyMzcvMzAwNjcxNTk3LWEyMGI0YWIwLWI5MmUtNDdmNy05M2FiLWZhODc0ZTc3NDEwOC5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMDE2NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ZGM5NzRkZmNmMTJjOWEyOTkxZGY3MGY2OWYxOGFjYzkzYTE3Y2UyMDI1MzU4MjU1ZWZjYmI3MTdkYzY0ODU4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.PGLitgazJ-UOCjFpGAVuR7XKtpgUdwm-Cu1bMNXLAX0)
^This would previously caused the button to have the correct background-color!
🚧 Summary
When the button was focused, this caused the NcButton to have these styles applied : https://github.com/nextcloud-libraries/nextcloud-vue/blob/c39a05682403a19d5ba6e8699ca496e28daa4232/src/components/NcActions/NcActions.vue#L1669
Arguably, you could say that I should edit the components styles here - however, they where added for a reason, and changing that styling could cause regressions all around the server, so its best to change it personally within the viewers view!
Checklist
Code is properly formatted
Sign-off message is added to all commits
[ ] Tests (unit, integration, api and/or acceptance) are included
[x] Screenshots before/after for front-end changes
[x] Documentation (manuals or wiki) has been updated or is not required
[x] Backports requested where applicable (ex: critical bugfixes)