Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Videos.vue #2349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Videos.vue #2349

wants to merge 1 commit into from

Conversation

sptcguy
Copy link

@sptcguy sptcguy commented Jul 8, 2024

Remove video{ max-height } attribute.

This fixes #1831

Remove video{ max-height } attribute.

Signed-off-by: sptcguy <[email protected]>
@artonge
Copy link
Contributor

artonge commented Jul 8, 2024

@hamza221 seems like you changed that line to fix full screen on iOS: #1819
Could you two ensure there is no regression from this change?

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

@hamza221 seems like you changed that line to fix full screen on iOS: #1819 Could you two ensure there is no regression from this change?

@hamza221 any news?

@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature 3. to review Waiting for reviews labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical video aspect ratio wrong in public view
3 participants