Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined filename in livephoto #2418

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

skjnldsv
Copy link
Member

TypeError: Cannot read properties of undefined (reading 'startsWith')
    at getDavPath (viewer-main.mjs?v=4627e4c8-1765:27012:16)
    at VueComponent.livePhotoDavPath (viewer-main.mjs?v=46…e4c8-1765:121693:31)
    at Watcher2.get (viewer-main.mjs?v=4627e4c8-1765:2300:30)
    at Watcher2.evaluate (viewer-main.mjs?v=4627e4c8-1765:2371:25)
    at VueComponent.computedGetter [as livePhotoDavPath] (viewer-main.mjs?v=4627e4c8-1765:3561:17)
    at VueComponent.livePhotoSrc (viewer-main.mjs?v=46…e4c8-1765:121689:45)

No idea how to properly reproduce this, but I've had reports and experienced it myself

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 13, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Aug 13, 2024
@skjnldsv skjnldsv self-assigned this Aug 13, 2024
@skjnldsv skjnldsv force-pushed the fix/filename-requirements branch from 688f9ba to e3dc48f Compare August 13, 2024 15:00
Copy link

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/filename-requirements branch from e3dc48f to bf06f3f Compare August 13, 2024 15:16
@skjnldsv skjnldsv merged commit c6d57a2 into master Aug 13, 2024
31 checks passed
@skjnldsv skjnldsv deleted the fix/filename-requirements branch August 13, 2024 15:47
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Aug 13, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Aug 13, 2024
Copy link

backportbot bot commented Aug 13, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2418/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bf06f3f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2418/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants