Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strictify live photo condition to prevent false positive #2442

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Aug 27, 2024

If an item in the file list has an undefined fileid, this would have brought a false positive, causing an issue when rendering the file.

Might fix #2170

@artonge artonge self-assigned this Aug 27, 2024
@artonge artonge added 3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket labels Aug 27, 2024
@artonge artonge added this to the Nextcloud 31 milestone Aug 27, 2024
@artonge
Copy link
Contributor Author

artonge commented Aug 27, 2024

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Aug 27, 2024

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Aug 27, 2024
@artonge artonge requested a review from skjnldsv August 27, 2024 12:48
@artonge artonge force-pushed the artonge/stritify_live_photos_condition branch from 62927a2 to 83e5256 Compare August 27, 2024 12:52
@artonge artonge requested a review from susnux August 28, 2024 08:58
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@artonge artonge merged commit 6086797 into master Aug 28, 2024
28 checks passed
@artonge artonge deleted the artonge/stritify_live_photos_condition branch August 28, 2024 19:22
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Media not showing in preview in File App
2 participants