Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix: Make loading the viewer an init script #2488

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 9, 2024

Backport of #2486

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from mejo- and susnux September 9, 2024 13:33
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Sep 9, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Sep 9, 2024
@susnux susnux force-pushed the backport/2486/stable30 branch from 70739aa to ae5fcfc Compare September 9, 2024 13:54
@susnux susnux requested a review from juliusknorr September 9, 2024 13:55
@susnux
Copy link
Contributor

susnux commented Sep 9, 2024

/compile

@susnux susnux marked this pull request as ready for review September 9, 2024 13:55
@mejo- mejo- force-pushed the backport/2486/stable30 branch from 57397a9 to 7fa8b98 Compare September 11, 2024 20:27
@susnux
Copy link
Contributor

susnux commented Sep 11, 2024

/compile

@mejo-
Copy link
Member

mejo- commented Sep 11, 2024

@susnux I made a quick attempt at rebasing the PR but now Cypress tests fail. If you have time to look into it, that'd be great ❤️

@susnux susnux force-pushed the backport/2486/stable30 branch from 7107340 to 4e830ff Compare September 11, 2024 21:51
@susnux
Copy link
Contributor

susnux commented Sep 11, 2024

@susnux I made a quick attempt at rebasing the PR but now Cypress tests fail. If you have time to look into it, that'd be great ❤️

Only the snapshots are failing but i can not update them locally...

@mejo-
Copy link
Member

mejo- commented Sep 11, 2024

Only the snapshots are failing but i can not update them locally...

Alright, I updated them now from the CI run ...

@skjnldsv skjnldsv force-pushed the backport/2486/stable30 branch from d74149b to a827492 Compare September 14, 2024 17:02
@skjnldsv skjnldsv merged commit 26600d2 into stable30 Sep 14, 2024
28 checks passed
@skjnldsv skjnldsv deleted the backport/2486/stable30 branch September 14, 2024 18:04
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants