Fix nginx config example #239
Conversation
Signed-off-by: Dennis Brakhane <[email protected]>
| @@ -101,7 +101,7 @@ location /whiteboard/ { | |||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | |||
| proxy_set_header Host $host; | |||
|
|
|||
| proxy_pass http://localhost:3002; | |||
| proxy_pass http://localhost:3002/; | |||
There was a problem hiding this comment.
Apache configuration is missing
There was a problem hiding this comment.
That's why it says "nginx config example" ;)
I have no idea how Apache handles it and if it needs a slash or not. From what I remember, it's nginx that is particularly picky about trailing slashes changing how requests are passed on. :)
There was a problem hiding this comment.
i approve jour PR for nginx🙂
|
Sorry to read your PR after pushing mine. |
|
Thanks a lot for your PR, unfortunately I came by reviewing #242 earlier, so I merged that one instead. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Due to how proxy_pass works in nginx, we need a slash at the end, otherwise, nginx will send the request as "/whiteboard/signal.io", which is not what the whiteboard server expects.
This is probably the reason for #193