Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add save button #263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add save button #263

wants to merge 3 commits into from

Conversation

grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Nov 5, 2024

We keep getting issues from users complaining abt whiteboard not saving/beeing confused with when it's supposed to save.
I think we should add this button as text has it. That way users get feedback that their process is not lost.

image

@nextcloud/designers any objections on this?

Signed-off-by: grnd-alt <[email protected]>
@szaimen
Copy link
Contributor

szaimen commented Nov 7, 2024

@nextcloud/designers any objections on this?

Sounds good to have a dedicated save button imo :)

@grnd-alt grnd-alt self-assigned this Nov 13, 2024
@hweihwang
Copy link
Contributor

Looks good, tested works well at my local. But imo not a big fan of a Save button in the context of collaborative tools since when, where, how to save should automatically, properly handled in the whiteboard server. Prefer to rather do a periodically saved to Nextcloud server and notify users if any issues occurred.

This is related and can resolve the saving issue #238 by:

But the Save button is still good so we can perform a check to save when users needed and will save users' data in case server got crashed like at #258, but maybe need to add a notification for user when saving is failed @grnd-alt with some proper messages

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on that this shouldn't be a button, but a non interactive element instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

4 participants