-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add save button #263
base: main
Are you sure you want to change the base?
add save button #263
Conversation
Signed-off-by: grnd-alt <[email protected]>
Signed-off-by: grnd-alt <[email protected]>
Sounds good to have a dedicated save button imo :) |
Signed-off-by: grnd-alt <[email protected]>
Looks good, tested works well at my local. But imo not a big fan of a Save button in the context of collaborative tools since when, where, how to save should automatically, properly handled in the whiteboard server. Prefer to rather do a periodically saved to Nextcloud server and notify users if any issues occurred. This is related and can resolve the saving issue #238 by:
But the Save button is still good so we can perform a check to save when users needed and will save users' data in case server got crashed like at #258, but maybe need to add a notification for user when saving is failed @grnd-alt with some proper messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on that this shouldn't be a button, but a non interactive element instead.
We keep getting issues from users complaining abt whiteboard not saving/beeing confused with when it's supposed to save.
I think we should add this button as text has it. That way users get feedback that their process is not lost.
@nextcloud/designers any objections on this?