fix: prevent preview div from collapsing to 0px height #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grnd-alt
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Thanks for your first contribution 🎉
I've tested your pull request and it does make the whiteboard visible, though the toolbar is not rendered, and one can't edit.
If you get your DCO check green I think we can get this merged for now!
I will then create a ticket to fix the rest of it.
Signed-off-by: Peter Birrer <[email protected]>
pbirrer
force-pushed
the
fix/text-app-preview
branch
from
ef8ada8
to
0ecf9d2
Compare
|
I believe the Excalidraw widget is intentionally set to read-only mode in the preview, which makes sense. However, it would be great if the menu bar at the bottom could be removed in the preview for a cleaner look. |
grnd-alt
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whiteboard preview in the text app editor is currently collapsing entirely, rendering it unusable. This issue has been observed in both Firefox and Chromium browsers. This commit addresses the problem by setting a minimum height of 400px for the preview, ensuring it remains visible and functional.
From:
To:
@nextcloud/designers: Are there any potential impacts this change might have on other parts of the application?