Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

delete v2.0 docs #168

Merged
merged 1 commit into from
Apr 3, 2024
Merged

delete v2.0 docs #168

merged 1 commit into from
Apr 3, 2024

Conversation

nvnieuwk
Copy link
Collaborator

@nvnieuwk nvnieuwk commented Apr 3, 2024

No description provided.

@nvnieuwk nvnieuwk requested a review from mirpedrol April 3, 2024 07:53
mirpedrol
mirpedrol approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But we should fix the version in MANIFEST.MF, otherwise the docs will be generated again if we push new changes to master

@nvnieuwk
Copy link
Collaborator Author

nvnieuwk commented Apr 3, 2024

LGTM! But we should fix the version in MANIFEST.MF, otherwise the docs will be generated again if we push new changes to master

I disabled the github action in #163 so the docs won't be regenerated when that PR is merged

@mirpedrol
Copy link
Collaborator

I disabled the github action in #163 so the docs won't be regenerated when that PR is merged

Perfect! looks good then 🙂

@nvnieuwk nvnieuwk merged this pull request into gh-pages Apr 3, 2024
@nvnieuwk nvnieuwk deleted the delete-v2.0-docs branch April 3, 2024 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @mirpedrol