Fix Date(time) instance in primary key #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, as you can see, since updates to other rdbms' it is best to keep changes as small as possible. Please, fix all build issues. Thx. |
|
Yes, working on it. for MySQL specifically I will look into that too |
|
Oh, sorry, that something that broke and I hadn't time to fix it. If you don't want, let fixing this on me. |
jkavalik
force-pushed
the
DatetimePK
branch
8 times, most recently
from
fbcba0e to
f987af7
Compare
hrach
reviewed
Oct 8, 2024
Comment on lines
79
to
80
| $res = $this->orm->userStatsX->getBy(['date' => new DateTime('2019-01-01')]); | ||
| Assert::notNull($res); |
|
Awesome <3 |
|
I replaced getBy(Id)/assertNotNull by their checked variant in the files tests I touched (except the case where it would lead to unused variable). |
|
@jkavalik could you please fixup relevant commits, i.e. keep split fixing CI; and then your fix with tests in another commit? thx |
|
Reordered and squashed |
|
Fixed a bad conflict resolution.. |
|
Thank you a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.