feat: add halo start indices to partition_metadata #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- minor tweaks to `DomainUtils` to add helper methods - `get_width` - `get_height` - added `Edge` enums and array `edges` for more readable loops over neighbours - reworked neighbour checking to be more consistent between periodic and non-periodic neighbours - add functionality to compute the starting indices for the halo regions in neighbouring domains - replaced loops over `NNBRS` to use the new `edges` enums - minor fix - ensure that `std::cerr` messages are followed by `exit(EXIT_FAILURE)`.
TomMelt
force-pushed
the
add-halo-start-indices
branch
from
e040578 to
fc4afae
Compare
jwallwork23
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks @TomMelt. I have a few minor comments and a request for more information. Could you elaborate on what exactly is meant by "add functionality to compute the starting indices for the halo regions in neighbouring domains"?
TomMelt
force-pushed
the
add-halo-start-indices
branch
from
f810ef9 to
8bdc0fe
Compare
jwallwork23
reviewed
Nov 8, 2024
jwallwork23
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to send halo regions via MPI in the dynamics, we need to know the size of the domains and the starting indices of the halo regions.
This PR adds functionality we need to parallelize nextsimdg dynamics.
The following improvements have been made.
DomainUtilsto add helper methodsget_widthget_heightEdgeenums and arrayedgesfor more readable loops over neighboursNNBRSto use the newedgesenumsstd::cerrmessages are followed byexit(EXIT_FAILURE).TODO
halo_starts)