Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor improvements to test #162

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

test: minor improvements to test #162

wants to merge 18 commits into from

Conversation

TAG-Epic
Copy link
Member

@TAG-Epic TAG-Epic commented Jan 6, 2023 •
edited
Loading

  • Lint tests (this will cause a few typing issues which will need to be fixed)
  • Improve coverage

Not sure if trying to get a high coverage is worth it, especially with some pretty bad tests.

TODOS:

  • Decompressor tests
  • Fix pyright not detecting unused parameters
  • shard tests
  • shard manager tests
  • make tests more reliable (might fail during higher CPU usage)
  • Fix Bucket doesnt release request if there is only one request pending. #163 (currently breaking a test)
  • Split decompressor tests
  • Testing directly against discord
  • Use a version of pytest-harmony from pypi
  • Redo pytest-harmony to be dependency based

@TAG-Epic
test: minor improvements to test
9016eba 
- Lint tests (this will cause a few typing issues which will need to be
  fixed)
- Improve coverage

Not sure if trying to get a high coverage is worth it, especially with
some pretty bad tests.
@TAG-Epic TAG-Epic added the type/tests Improve tests label Jan 6, 2023
@TAG-Epic
Copy link
Member Author

TAG-Epic commented Jan 6, 2023

Currently using codecov to check how im doing on tests, unfortunately it has some issues with TYPE_CHECKING imports

@TAG-Epic TAG-Epic mentioned this pull request Jan 17, 2023
Open
@TAG-Epic TAG-Epic mentioned this pull request Jan 19, 2023
Open
@TAG-Epic TAG-Epic mentioned this pull request Feb 8, 2023
Open
@TAG-Epic TAG-Epic marked this pull request as draft March 16, 2023 10:26
@TAG-Epic TAG-Epic mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/tests Improve tests
Projects
Nextcore
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket doesnt release request if there is only one request pending.
1 participant
@TAG-Epic