fix(HTTPClient): use orjson if it's installed #262
Conversation
|
What about json_loads? |
|
Oh, whoops. |
|
Nevermind, this PR isn't going to work. Sorry, I got confused and thought |
|
we do still dump so the PR is useful. We do also want something for deserialization too, however! But one is still progress. |
|
|
||
| if TYPE_CHECKING: | ||
| from typing import Any, Final, Literal | ||
|
|
||
| # ClientResponse is still imported here because ours is "incompatible" |
There was a problem hiding this comment.
This is incredibly cursed. Wouldnt it make more sense to make ours compatible?
There was a problem hiding this comment.
Pyright isn't being specific on how it's "incompatible", so I'm not sure how to make it compatible.
There was a problem hiding this comment.
/nextcore/nextcore/http/client/client.py:316:28 - error: Expression of type "ClientResponse" cannot be assigned to return type "ClientResponse"
"aiohttp.client_reqrep.ClientResponse" is incompatible with "nextcore.http.client.client_response.ClientResponse" (reportGeneralTypeIssues)
Here's what I'm getting, for reference.
There was a problem hiding this comment.
Weird. Will look into it eventually tm
#229