Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When selecting "events" in entropy panel, tooltip wrongly states "Normalized Shannon entropy" instead of "Number of events" #1905

Closed
corneliusroemer opened this issue Nov 16, 2024 · 1 comment · Fixed by #1906
Closed

When selecting "events" in entropy panel, tooltip wrongly states "Normalized Shannon entropy" instead of "Number of events" #1905

corneliusroemer opened this issue Nov 16, 2024 · 1 comment · Fixed by #1906
Labels
bug Something isn't working

Comments

@corneliusroemer
Copy link
Member

Brave Browser 2024-11-16 17 27 25

Seen on next.nextstrain.org = 2.61.1 at time of writing
@corneliusroemer corneliusroemer added the bug Something isn't working label Nov 16, 2024
@jameshadfield
Copy link
Member

jameshadfield commented Nov 17, 2024 •
edited
Loading

Bisecting points to

0c91724786d5b7f556defbcd002a9c003fac4962 is the first bad commit
commit 0c91724786d5b7f556defbcd002a9c003fac4962
Author: james hadfield
Date:   Mon Oct 28 13:52:20 2024 +1300

    [entropy] improve performance of entropy calcs

jameshadfield added a commit that referenced this issue Nov 17, 2024
@jameshadfield
[entropy] Fix out-of-sync entropy-events state
ca88ae8 
Changing between "Entropy - Events" results in two dispatches
(`ENTROPY_COUNTS_TOGGLE` and `ENTROPY_DATA`) however the entropy code
would ignore the first update if it didn't contain new entropy data.
This bug has probably existed for the life of the entropy panel however
was masked by those two actions happening back-to-back and being
(always?) bundled together by redux.

Recent work in #1879 (v2.60.0) meant these actions were no longer
back-to-back and thus the bug was revealed.

Closes #1905
@jameshadfield jameshadfield mentioned this issue Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Entropy bug fixes nextstrain/auspice
2 participants
@jameshadfield @corneliusroemer