Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phylo: clean rule removes the USVI data #37

Closed
joverlee521 opened this issue Feb 23, 2024 · 1 comment · Fixed by #38
Closed

phylo: clean rule removes the USVI data #37

joverlee521 opened this issue Feb 23, 2024 · 1 comment · Fixed by #38
Labels
bug Something isn't working

Comments

@joverlee521
Copy link
Contributor

Running the clean rule in the phylogenetic workflow removes the USVI data that was added in #31

So if you run clean then try to run the workflow, it results in an error:

$ nextstrain build phylogenetic/ clean
...
$ nextstrain build phylogenetic/ 
Building DAG of jobs...
MissingInputException in rule append_usvi in file /nextstrain/build/rules/merge_sequences_usvi.smk, line 24:
Missing input files for rule append_usvi:
    output: data/sequences_all.fasta, data/metadata_all.tsv
    affected files:
        data/metadata_usvi.tsv
        data/sequences_usvi.fasta

Possible solution

I think easiest to just move the USVI data to a different directory, e.g. usvi_data, so that it does not get removed with the workflow data.

@joverlee521 joverlee521 added the bug Something isn't working label Feb 23, 2024
@j23414
Copy link
Contributor

j23414 commented Feb 23, 2024

Other options include:

  • moving USVI data back to being downloading from a URL (I think we didn't go this route because we wanted the README documentation?)
  • more specifically cleaning up data/metadata.tsv, data/sequences.fasta, data/metadata_all.tsv, and data/sequences_all.fasta at
    "data ",
    which would bypass creating another directory
  • creating a local_data folder instead where users can spike in any of their own sequences and records

@j23414 j23414 linked a pull request Feb 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants