Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add aws_anonymous profile #549

Closed
wants to merge 3 commits into from

Conversation

maxulysse
Copy link
Member

to simplify --no-sign-request usage with aws cli

@FriederikeHanssen
Copy link
Contributor

How about adding this to awsbatch config directly? It should solve the issues with igenomes for everyone, right?

@maxulysse
Copy link
Member Author

not sure we want that actually.
People might already have solved that on their side.
This is just to make it work for anyone wherever.

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing adding to README (maybe under a special section), but otherwise LGTM

docs/aws_anonymous.md Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
@maxulysse
Copy link
Member Author

Missing adding to README (maybe under a special section), but otherwise LGTM

for me mainly missing if we actually want to do that or not...

@ewels
Copy link
Member

ewels commented Feb 9, 2024

I have a feeling that this will break people's AWS batch workflows, as sign requests are needed to access most user-specific resources (legitimately). This will disable all sign requests for anything in the workflow.. It'd be good if someone could confirm?

See related: nextflow-io/nextflow#4732

@maxulysse
Copy link
Member Author

I have a feeling that this will break people's AWS batch workflows, as sign requests are needed to access most user-specific resources (legitimately). This will disable all sign requests for anything in the workflow.. It'd be good if someone could confirm?

See related: nextflow-io/nextflow#4732

Yeah, I'm not fully happy with it, which is why I haven't merged it now, I know it can solve some issue for some people, but I'm afraid it'll break stuff for other people.

@jfy133 jfy133 marked this pull request as draft May 15, 2024 18:13
@jfy133
Copy link
Member

jfy133 commented May 15, 2024

@maxulysse converting to draft. As you said relatively recently you're still unsure but could be relevant I'll leave it here for now. Please otherwise merge/close as necessary

@maxulysse
Copy link
Member Author

Let's just close it

@maxulysse maxulysse closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants