-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add aws_anonymous profile #549
Conversation
How about adding this to awsbatch config directly? It should solve the issues with igenomes for everyone, right? |
not sure we want that actually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing adding to README (maybe under a special section), but otherwise LGTM
Co-authored-by: James A. Fellows Yates <[email protected]>
for me mainly missing if we actually want to do that or not... |
I have a feeling that this will break people's AWS batch workflows, as sign requests are needed to access most user-specific resources (legitimately). This will disable all sign requests for anything in the workflow.. It'd be good if someone could confirm? See related: nextflow-io/nextflow#4732 |
Yeah, I'm not fully happy with it, which is why I haven't merged it now, I know it can solve some issue for some people, but I'm afraid it'll break stuff for other people. |
@maxulysse converting to draft. As you said relatively recently you're still unsure but could be relevant I'll leave it here for now. Please otherwise merge/close as necessary |
Let's just close it |
to simplify --no-sign-request usage with aws cli