FEAT: Add software_license profile #551
Conversation
conf/nfcore_license.config
Outdated
|
|
||
| process { | ||
| withLabel: 'sentieon' { | ||
| ext.sentieon_auth_mech_base64 = secrets.SENTIEON_AUTH_MECH_BASE64 ?: '' |
There was a problem hiding this comment.
secrets.SENTIEON_AUTH_MECH_BASE64 ?: '' failed for Ram when secrets.SENTIEON_AUTH_MECH_BASE64 wasn't set. He got
Unknown config secret 'SENTIEON_AUTH_MECH_BASE64'
There was a problem hiding this comment.
So the idea is to have many different licenses in conf/nfcore_license.config? 🤔 I wonder if that will work. Say nfcore_license.config refers to nf secrets for tool X and tool Y but the user only has license for X and can only set the nf secrets for X, then it seems to me that this will fail with err msg about missing nf-secrets for tool Y (that is, the same kind of error which we get from running profile test_cache without sentieon test-license nf-secrets set).
Maybe the config should just be for the sentieon test license? Perhaps name it sentieon_license_server_extension.config or sentieon_test_license.config instead of nfcore_license.config?
There was a problem hiding this comment.
yeah, this should only works when we set up secrets when we start the tests, similarly to how we do it within our CI
There was a problem hiding this comment.
It's nothing to do with a 'test license' so we can't call it 'test'.
maxulysse
changed the title
Co-authored-by: Adam Talbot <[email protected]>
to simplify GHA with Sentieon for pipelines and modules