-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed all SBC ShARC configs/docs and replaced with TUoS Stanage #552
Removed all SBC ShARC configs/docs and replaced with TUoS Stanage #552
Conversation
…s for TUoS Stanage
I see they were there before, but what's the purpose of all those pipeline specific configs? Without checking it looks like the standard config has just been brought in which seems to be a less than great idea - if any, can you please just include the bits that differ (and since you know the resources available, no need for check_max and so on). |
They have been modified from the base config and aren't just a direct copy and are the resource requests that have been tested for each pipeline. They were there before for the previous cluster for the same reason. We have had a number of times where a pipeline version has changed and has stopped working due to the pipeline resources changing, so we have started locking the versions we use. Check_max is included as, for whatever reason, if it isn't included here automatic retry doesn't work. |
I took a look and am not convinced:
"Locking versions" (e.g. deciding for one version to be used consistently within a project) is likely a good idea most of the time, but that is another thing from having profile specific configurations for pipelines - having such those rather makes it more likely there will be problems, especially if it's a copy of all settings rather than bringing in specific settings one want to address for whatever reason. (Example: sarek sees that fastp rather makes it through with 4 Gbyte of RAM and changes the configuration for that to default to multiples of 6 Gbytes, but as there's a pipeline specific configuration overriding that, those that run with that profile don't get the benefit of that but either need to tune themselves or let their jobs fail with the lower setting and then be retried.) |
I have removed all pipeline specific configurations and related documents. If the requirements for a PR to be approved are more fastidious than the checklist provided, perhaps it needs an update 🤔 |
Notice that I didn't require changes :) I understand if it seems odd getting these comments now if you didn't the last time, but the configs are pretty dependent on someone using the sites to submit updates when needed, and a lot of the time it's probably just reviewed favourably if nothing sticks out. As for these, as they don't differ, they don't break anything (now), they just don't seem like a good idea at all to me (e.g. can be confusing). |
name: Config for TUoS Stanage
about: Replacement for SBC ShARC
Please follow these steps before submitting your PR:
[WIP]
in its titlemaster
branchSteps for adding a new config profile:
conf/
directorydocs/
directorynfcore_custom.config
file in the top-level directoryREADME.md
file in the top-level directoryprofile:
scope in.github/workflows/main.yml