Use new nf-test features (#6286)

* ci: Attempt to split everything out

Don't hate me Adam

* ci: Add changed since, sharding, and ci

* ci: Add filter to try to get jobs split up

* ci: Switch to only-changed

* ci: See if follow-dependencies works without "related-tests"

* ci: Remove skipped tests

Idk what we're going to do about these...

* ci: Actually use the nf-test version

* ci: module => process

* ci: Clean up job names

* dummy: Make a change

* ci: Skip test.tap

* ci: Add fetch-depth

* ci: Clean up name

* ci: Lint everything

* ci: Get the job names clean

* ci: Add hide-progress on linting

* ci: Add psuedocode for conda-fail.yml

https://nfcore.slack.com/archives/CJRH30T6V/p1724406283145319

* test: Snapshot the versions contents, not the hash

#6505

* ci: Keep running nf-core lint the way it was

Blocked by nf-core/tools#3140

* ci: Move conda skips out

* ci: Address a comment

* style: Move prettier and editorconfig to pre-commit

#4554 (comment)

* ci: Add note about nf-core lint pre-commit

* chore: Copy over conda skips

a004c86
2da71b7

* ci: only-changed => changed-since

* Add confirm-pass

* ci: dynamically set shards

* ci: Run 3 process jobs per CI run as an example

* install nf-test

* fix install nf-test

* fix install nf-test

* ci: Remove dynamic number of shards, and combine process and workflow filters

* ci: Remove variable Nextflow versions

* test: Update bowtie versions

* ci: Fix indention

* ci: We're not testing multiple python versions

* style: Clean up job names

* build: Remove invisible characters?

* test(bowtie): Bump snapshots

* style: Remove stray comment

* ci: Add GPU tests in their own workflows

These will only get trigger on the paths listed

* ci(gpu): Clean up triggers and make a note about

how to make the includes smarter

* ci: pip install cryptography

* ci: Try removing path

* ci: Add fetch-depth and remove duplicate checkout

* test: Remove the second gpu profile

* ci: Add path back in

* ci(gpu): Remove changed-since

* ci: Fix missed dorny/paths-filter update

Co-authored-by: mashehu <[email protected]>

* Add changes from codereview

Co-authored-by: mashehu <[email protected]>

* style: Remove example TODO comments

https://github.com/nf-core/modules/pull/6286/files#r1846856369
Co-authored-by: mashehu <[email protected]>

* refactor: Try tags for GPU CI

askimed/nf-test#272

* style: Set NFT_WORKDIR as an ENV variable

* style: Run lsp format on a parabricks module

For science

* test: Add gpu tags to parabricks

* ci: Split tags out of matrix

* Revert "style: Run lsp format on a parabricks module"

This reverts commit d134e78.

* ci: Fix name

---------

Co-authored-by: Edmund Miller <[email protected]>
Co-authored-by: maxulysse <[email protected]>
Co-authored-by: mashehu <[email protected]>

.github/actions/nf-test-action/action.yml

@@ -1,18 +1,22 @@
 name: "nf-test Action"
 description: "Runs nf-test with common setup steps"
 inputs:
-  path:
-    description: "Path to test"
-    required: true
   profile:
     description: "Profile to use"
     required: true
+  shard:
+    description: "Shard number for this CI job"
+    required: true
+  total_shards:
+    description: "Total number of test shards(NOT the total number of matrix jobs)"
+    required: true
+  tags:
+    description: "Tags to test (`<tags>[,<tags>...]`)"
+    required: false
 
 runs:
   using: "composite"
   steps:
-    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-
     - uses: actions/setup-java@8df1039502a15bceb9433410b1a100fbe190c53b # v4
       with:
         distribution: "temurin"
@@ -56,20 +60,31 @@ runs:
       if: env.SENTIEON_ENCRYPTION_KEY != '' && env.SENTIEON_LICENSE_MESSAGE != ''
       shell: bash
       run: |
+        python -m pip install cryptography
         nextflow secrets set SENTIEON_AUTH_DATA $(python3 tests/modules/nf-core/sentieon/license_message.py encrypt --key "$SENTIEON_ENCRYPTION_KEY" --message "$SENTIEON_LICENSE_MESSAGE")
 
+      # TODO Skip failing conda tests and document their failures
+      # https://github.com/nf-core/modules/issues/7017
     - name: Run nf-test
       shell: bash
       env:
         SENTIEON_LICSRVR_IP: ${{ env.SENTIEON_LICSRVR_IP }}
         SENTIEON_AUTH_MECH: "GitHub Actions - token"
+        TAGS: ${{ inputs.tags && format('--tag {0}', inputs.tags) || '' }}
+        NFT_WORKDIR: "~"
       run: |
-        NFT_WORKDIR=~ \
         nf-test test \
           --profile=${{ inputs.profile }} \
           --tap=test.tap \
           --verbose \
-          ${{ inputs.path }}
+          --ci \
+          --changed-since HEAD^ \
+          --shard ${{ inputs.shard }}/${{ inputs.total_shards }} \
+          --filter process,workflow \
+          --follow-dependencies \
+          ${{ env.TAGS }}
+
+      # TODO If no test.tap, then make one to spoof?
     - uses: pcolby/tap-summary@0959cbe1d4422e62afc65778cdaea6716c41d936 # v1
       if: ${{ inputs.path != '' }}
       with:

.github/conda_skip.yml

@@ -0,0 +1,184 @@
+# TODO What do we do with these?
+# I think we can require Docker,modules,Shard 1..Singularity,subworkflows,3 and skip the condas now
+exclude:
+  - path: modules/nf-core/nf-test
+  - profile: conda
+    path: modules/nf-core/angsd/gl
+  - profile: conda
+    path: modules/nf-core/annotsv/installannotations
+  - profile: conda
+    path: modules/nf-core/happy/sompy
+  - profile: conda
+    path: modules/nf-core/backsub
+  - profile: conda
+    path: modules/nf-core/bakta/bakta
+  - profile: conda
+    path: modules/nf-core/bakta/baktadbdownload
+  - profile: conda
+    path: modules/nf-core/bases2fastq
+  - profile: conda
+    path: modules/nf-core/bcl2fastq
+  - profile: conda
+    path: modules/nf-core/bclconvert
+  - profile: conda
+    path: modules/nf-core/celesta
+  - profile: conda
+    path: modules/nf-core/cellpose
+  - profile: conda
+    path: modules/nf-core/cellranger/count
+  - profile: conda
+    path: modules/nf-core/cellranger/mkfastq
+  - profile: conda
+    path: modules/nf-core/cellranger/mkgtf
+  - profile: conda
+    path: modules/nf-core/cellranger/mkref
+  - profile: conda
+    path: modules/nf-core/cellranger/mkvdjref
+  - profile: conda
+    path: modules/nf-core/cellranger/multi
+  - profile: conda
+    path: modules/nf-core/cellranger/vdj
+  - profile: conda
+    path: modules/nf-core/checkqc
+  - profile: conda
+    path: modules/nf-core/custom/dumpsoftwareversions
+  - profile: conda
+    path: modules/nf-core/deepcell/mesmer
+  - profile: conda
+    path: modules/nf-core/deepsomatic
+  - profile: singularity
+    path: modules/nf-core/deepsomatic
+  - profile: conda
+    path: modules/nf-core/deepvariant
+  - profile: conda
+    path: modules/nf-core/deepvariant/callvariants
+  - profile: conda
+    path: modules/nf-core/deepvariant/makeexamples
+  - profile: conda
+    path: modules/nf-core/deepvariant/postprocessvariants
+  - profile: conda
+    path: modules/nf-core/deepvariant/rundeepvariant
+  - profile: conda
+    path: modules/nf-core/deepvariant/vcfstatsreport
+  - profile: conda
+    path: modules/nf-core/doubletdetection
+  - profile: conda
+    path: modules/nf-core/ensemblvep/vep
+  - profile: conda
+    path: modules/nf-core/fastk/fastk
+  - profile: conda
+    path: modules/nf-core/cellrangerarc/mkgtf
+  - profile: conda
+    path: modules/nf-core/fastk/histex
+  - profile: conda
+    path: modules/nf-core/fastk/merge
+  - profile: conda
+    path: modules/nf-core/fcs/fcsadaptor
+  - profile: conda
+    path: modules/nf-core/fcs/fcsgx
+  - profile: conda
+    path: modules/nf-core/ganon/buildcustom
+  - profile: conda
+    path: modules/nf-core/ganon/classify
+  - profile: conda
+    path: modules/nf-core/ganon/report
+  - profile: conda
+    path: modules/nf-core/ganon/table
+  - profile: conda
+    path: modules/nf-core/gatk4/cnnscorevariants
+  - profile: conda
+    path: modules/nf-core/gatk4/determinegermlinecontigploidy
+  - profile: conda
+    path: modules/nf-core/genescopefk
+  - profile: conda
+    path: modules/nf-core/ilastik/multicut
+  - profile: conda
+    path: modules/nf-core/ilastik/pixelclassification
+  - profile: conda
+    path: modules/nf-core/imputeme/vcftoprs
+  - profile: conda
+    path: modules/nf-core/mcstaging/imc2mc
+  - profile: conda
+    path: modules/nf-core/mcquant
+  - profile: conda
+    path: modules/nf-core/mcstaging/phenoimager2mc
+  - profile: conda
+    path: modules/nf-core/merquryfk/katcomp
+  - profile: conda
+    path: modules/nf-core/merquryfk/katgc
+  - profile: conda
+    path: modules/nf-core/merquryfk/merquryfk
+  - profile: conda
+    path: modules/nf-core/merquryfk/ploidyplot
+  - profile: conda
+    path: modules/nf-core/molkartgarage/clahe
+  - profile: conda
+    path: modules/nf-core/quartonotebook
+  - profile: conda
+    path: modules/nf-core/scimap/spatiallda
+  - profile: conda
+    path: modules/nf-core/sentieon/bwaindex
+  - profile: conda
+    path: modules/nf-core/sentieon/bwamem
+  - profile: conda
+    path: modules/nf-core/sentieon/datametrics
+  - profile: conda
+    path: modules/nf-core/sentieon/dedup
+  - profile: conda
+    path: modules/nf-core/sentieon/qualcal
+  - profile: conda
+    path: modules/nf-core/spaceranger/mkgtf
+  - profile: conda
+    path: modules/nf-core/spaceranger/mkref
+  - profile: conda
+    path: modules/nf-core/spaceranger/count
+  - profile: conda
+    path: modules/nf-core/spotiflow
+  - profile: conda
+    path: modules/nf-core/svanalyzer/svbenchmark
+  - profile: conda
+    path: modules/nf-core/universc
+  - profile: singularity
+    path: modules/nf-core/universc
+  - profile: conda
+    path: modules/nf-core/vt/decompose
+  - profile: singularity
+    path: modules/nf-core/bases2fastq
+  - profile: conda
+    path: modules/nf-core/wittyer
+  - profile: conda
+    path: modules/nf-core/islandpath
+  - profile: conda
+    path: modules/nf-core/scimap/mcmicro
+  - profile: conda
+    path: modules/nf-core/parabricks/fq2bammeth
+  - profile: docker_self_hosted
+    path: modules/nf-core/parabricks/fq2bammeth
+  - profile: singularity
+    path: modules/nf-core/parabricks/fq2bammeth
+  - profile: conda
+    path: modules/nf-core/parabricks/fq2bam
+  - profile: docker_self_hosted
+    path: modules/nf-core/parabricks/fq2bam
+  - profile: singularity
+    path: modules/nf-core/parabricks/fq2bam
+  - profile: conda
+    path: subworkflows/nf-core/vcf_annotate_ensemblvep
+  - profile: conda
+    path: subworkflows/nf-core/bcl_demultiplex
+  - profile: conda
+    path: subworkflows/nf-core/deepvariant
+  - profile: conda
+    path: subworkflows/nf-core/fastq_align_bamcmp_bwa
+  - profile: conda
+    path: subworkflows/nf-core/fastq_align_bwa
+  - profile: conda
+    path: subworkflows/nf-core/fasta_newick_epang_gappa
+  - profile: conda
+    path: modules/nf-core/xeniumranger/relabel
+  - profile: conda
+    path: modules/nf-core/xeniumranger/rename
+  - profile: conda
+    path: modules/nf-core/xeniumranger/resegment
+  - profile: conda
+    path: modules/nf-core/xeniumranger/import-segmentation

.github/workflows/gpu-tests.yml

@@ -0,0 +1,71 @@
+name: Run GPU nf-tests
+on:
+  push:
+    branches:
+      # https://docs.renovatebot.com/key-concepts/automerge/#branch-vs-pr-automerging
+      - "renovate/**" # branches Renovate creates
+  pull_request:
+    branches: [master]
+    paths:
+      - ".github/workflows/gpu-tests.yml"
+      - "modules/nf-core/parabricks/**"
+  merge_group:
+    types: [checks_requested]
+    branches: [master]
+  workflow_dispatch:
+    inputs:
+      runners:
+        description: "Runners to test on"
+        type: choice
+        options:
+          - "ubuntu-latest"
+          - "self-hosted"
+        default: "self-hosted"
+
+# Cancel if a newer run is started
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+env:
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  NFT_VER: "0.9.2"
+  NXF_ANSI_LOG: false
+  NXF_SINGULARITY_CACHEDIR: ${{ github.workspace }}/.singularity
+  NXF_SINGULARITY_LIBRARYDIR: ${{ github.workspace }}/.singularity
+  NXF_VER: "24.04.4"
+
+jobs:
+  nf-test-gpu:
+    runs-on: "gpu"
+    name: "GPU | ${{ matrix.tags}} | ${{ matrix.profile }} | ${{ matrix.shard }}"
+    strategy:
+      fail-fast: false
+      matrix:
+        shard: [1, 2]
+        profile: [docker_self_hosted, singularity] # conda?
+        # TODO Pass these in from GitHub PR trigger events
+        tags:
+          - parabricks/applybqsr
+          - parabricks/fq2bam
+          - parabricks/fq2bammeth
+    env:
+      NXF_ANSI_LOG: false
+      TOTAL_SHARDS: 2
+
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0
+      - name: Run nf-test Action
+        uses: ./.github/actions/nf-test-action
+        env:
+          SENTIEON_ENCRYPTION_KEY: ${{ secrets.SENTIEON_ENCRYPTION_KEY }}
+          SENTIEON_LICENSE_MESSAGE: ${{ secrets.SENTIEON_LICENSE_MESSAGE }}
+          SENTIEON_LICSRVR_IP: ${{ secrets.SENTIEON_LICSRVR_IP }}
+          SENTIEON_AUTH_MECH: "GitHub Actions - token"
+        with:
+          profile: ${{ matrix.profile }},gpu
+          shard: ${{ matrix.shard }}
+          total_shards: ${{ env.TOTAL_SHARDS }}
+          tags: ${{matrix.tags}},gpu