Skip to content

Commit

Permalink
refactor: Try tags for GPU CI
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundmiller committed Nov 18, 2024
1 parent 9d05040 commit e04d248
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
11 changes: 6 additions & 5 deletions .github/actions/nf-test-action/action.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: "nf-test Action"
description: "Runs nf-test with common setup steps"
inputs:
path:
description: "Path to test"
required: false
profile:
description: "Profile to use"
required: true
Expand All @@ -13,6 +10,9 @@ inputs:
total_shards:
description: "Total number of test shards(NOT the total number of matrix jobs)"
required: true
tags:
description: "Tags to test (`<tags>[,<tags>...]`)"
required: false

runs:
using: "composite"
Expand Down Expand Up @@ -70,18 +70,19 @@ runs:
env:
SENTIEON_LICSRVR_IP: ${{ env.SENTIEON_LICSRVR_IP }}
SENTIEON_AUTH_MECH: "GitHub Actions - token"
TAGS: ${{ inputs.tags && format('--tag {0}', inputs.tags) || '' }}
run: |
NFT_WORKDIR=~ \
nf-test test \
--profile=${{ inputs.profile }} \
--tap=test.tap \
--verbose \
--ci \
# FIXME this doesn't work with a path? --changed-since HEAD^ \
--changed-since HEAD^ \
--shard ${{ inputs.shard }}/${{ inputs.total_shards }} \
--filter process,workflow \
--follow-dependencies \
${{ inputs.path }}
${{ env.TAGS }}
# TODO If no test.tap, then make one to spoof?
- uses: pcolby/tap-summary@0959cbe1d4422e62afc65778cdaea6716c41d936 # v1
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/gpu-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jobs:
shard: [1, 2]
# TODO Pass these in from GitHub PR trigger events
include:
- path: modules/nf-core/parabricks/applybqsr
- tags: parabricks/applybqsr
profile: [docker_self_hosted, singularity]
- path: modules/nf-core/parabricks/fq2bam
- tags: parabricks/fq2bam
profile: [docker_self_hosted, singularity]
- path: modules/nf-core/parabricks/fq2bammeth
- tags: parabricks/fq2bammeth
profile: [docker_self_hosted, singularity]
env:
NXF_ANSI_LOG: false
Expand All @@ -67,8 +67,7 @@ jobs:
SENTIEON_LICSRVR_IP: ${{ secrets.SENTIEON_LICSRVR_IP }}
SENTIEON_AUTH_MECH: "GitHub Actions - token"
with:
path: ${{ matrix.path }}
profile: ${{ matrix.profile }},gpu
shard: ${{ matrix.shard }}
total_shards: ${{ env.TOTAL_SHARDS }}
# TODO Pass a "gpu" tag in case there's cpu only tests
tags: ${{matrix.tags}},gpu

0 comments on commit e04d248

Please sign in to comment.