UMICollapse module: Drop external dependencies from UMICollapse module tests #7075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the UMICollapse module tests run on data that is generated in the test
setup{}
with external dependencies (umitools/extract
,bwa/index
,bwa/mem
,samtools/index
). While this is no problem here in the modules' repository, those tests will fail on the pipeline level, if those additional modules are not available there.While it may, on the long-term, be useful to devise a CI step detecting and installing missing modules for tests (Leon Rauschning made a neat proposal for this), I have now, due to time contraints, opted to add the required files to the test datasets (test-datasets/1390) and change the tests accordingly (this PR).
I have also updated the
umi-tools dedup
tests, since they so far used inputs without UMIs.PR checklist
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda