-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update module_name filter step #7106
Draft
edmundmiller
wants to merge
15
commits into
master
Choose a base branch
from
modules_filter_function
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+103
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
reviewed
Nov 27, 2024
edmundmiller
force-pushed
the
modules_filter_function
branch
from
November 27, 2024 16:27
701fd07
to
f75b3fa
Compare
Co-authored-by: Matthias Hörtenhuber <[email protected]>
mashehu
approved these changes
Nov 27, 2024
MatthiasZepper
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now only tested the script in isolation, but the test cases pass for me locally as well. Thanks for the solid work!
Looking at the CI failure in this PR...can it be that it was only the missing bracket in the .map() function that caused all the issues?
|
This would've broken something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a small test script to prevent re-running into edge-cases and to quickly add new test cases. If we don't hate the idea I think we can wire it up to the javascript file to avoid any copy-paste errors.