Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk sort environment yamls #7372

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Bulk sort environment yamls #7372

merged 3 commits into from
Feb 4, 2025

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jan 27, 2025

Follow up to #7085

@maxulysse
Copy link
Member

while we're at it,
I know we're switching a lot for branch names around from master to main.
Do we want to plan for it here now, or in a separate PR?

@edmundmiller
Copy link
Contributor Author

Seperate PR, please!

In theory should:
- Sort dependencies
- Add yaml schema
- Remove quotes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bulk changes make me uneasy, but LGTM

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewels ewels merged commit 8188078 into master Feb 4, 2025
8 of 59 checks passed
@ewels ewels deleted the bulk-sort-env-yamls branch February 4, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants