Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quartonotebook #68

Closed
wants to merge 10 commits into from
Closed

Quartonotebook #68

wants to merge 10 commits into from

Conversation

fasterius
Copy link
Collaborator

@fasterius fasterius commented Feb 12, 2024 •
edited
Loading

This PR changes the use of local modules for the Quarto reports into using the QUARTONOTEBOOK nf-core module.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5226398

+| ✅ 172 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: assets/nf-core-spatialtranscriptomics_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-spatialtranscriptomics_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-spatialtranscriptomics_logo_dark.png
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-12 15:52:17

@fasterius fasterius self-assigned this Mar 4, 2024
@fasterius
Copy link
Collaborator Author

Closing this PR in favour of the consolidated #67.

@fasterius fasterius closed this Mar 7, 2024
@fasterius fasterius deleted the quartonotebook branch April 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fasterius fasterius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fasterius