Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating portal dataset schema for external viewers #455

Closed
anngvu opened this issue May 24, 2024 · 0 comments · Fixed by #453
Closed

Updating portal dataset schema for external viewers #455

anngvu opened this issue May 24, 2024 · 0 comments · Fixed by #453
Assignees
Labels
enhancement New feature or request rfc Request for comment / discussion

Comments

@anngvu
Copy link
Collaborator

anngvu commented May 24, 2024

The portal dataset schema defines how the card looks on the portal and what will be curated for a dataset. Currently, we want to provide links to external viewers where some or all of the dataset data are represented (cBioPortal, GEO, CELLxGENE, etc.). We have an option to

  1. define a specific attribute per viewer, e.g. viewcBioPortal + viewGEO
  • Perhaps clearer to users.
  1. alternatively, something like externalViewer which will contain a list of accessions
  • The simpler and more maintainable solution. There will be one-off viewers that are only relevant to one dataset, e.g. the data for Drug-Target Explorer has a bespoke Shiny app as the external viewer... Adding 20 different columns per viewer is not great.
  • Perhaps too generic and therefore confusing to users.

More pros and cons...
@allaway @jaybee84 @cconrad8

@anngvu anngvu added enhancement New feature or request rfc Request for comment / discussion labels May 24, 2024
@anngvu anngvu linked a pull request May 24, 2024 that will close this issue
@anngvu anngvu moved this to In Progress in NF-OSI Sprints May 24, 2024
@anngvu anngvu self-assigned this May 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rfc Request for comment / discussion
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant