You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a mockup of what this might look like in the UI (maybe fancier than a link, should be an icon specific to the viewer). This would be useful for known viewers that can be linked to via a constant accession/url, such as cBioPortal, GEO, CELLxGENE.
Update: Suggestion for a better term other than "externalViewer" welcome.
know we talked about this before and perhaps we decided against it, but one way to avoid a confusing catch-all term would be to add attributes for each of our external viewers, so instead of external viewer it could be something like view dataset on cbioportal and view dataset on cellxgene.
A thought related to the above is that the portals already support linking to arbitrary identifiers (as long as you can come up with a regex for them) thanks to work @jay-hodgson and @cconrad8 did for the NFTC database. So, if we used the above approach, we could add it on our end as cbioportal:nst_nfosi_ntap and use the SRC feature to autolink that to https://identifiers.org/cbioportal:nst_nfosi_ntap (or any other value with a cbioportal: prefix)
@allaway Yeah, I know there's the attribute-per-viewer option, and I have reasons for not liking it. But anyway, there wasn't a pros and cons written down anywhere that I can find, so created issue #455 for more formal discussion/design documentation.
Good to know about the identifiers prefix!
anngvu
linked an issue
May 24, 2024
that may be
closed
by this pull request
@jaybee84 I likke Explore Insights and visualize data on! If we start linking to other raw data I think we should categorize that separately anyway, so probably not too much of a problem (does not work for link to GEO/SRA (that might be okay since this is specifically for viewers)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a mockup of what this might look like in the UI (maybe fancier than a link, should be an icon specific to the viewer). This would be useful for known viewers that can be linked to via a constant accession/url, such as cBioPortal, GEO, CELLxGENE.
Update: Suggestion for a better term other than "externalViewer" welcome.