Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/json schema workflow #399

Merged
merged 20 commits into from
Mar 7, 2024
Merged

Feat/json schema workflow #399

merged 20 commits into from
Mar 7, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Feb 22, 2024

This implements needed changes described in #398.
Previously schemas were re-registered manually after updates, but it would be better to build it into the workflow.

So this has two parts:

First, when something like modules/Assay changes, the JSON schemas need to be rebuilt, similar to how NF.jsonld is rebuilt. NF.jsonld format "targets" the DCA application, while json format "targets" the Synapse platform.

You can see this in how files changed not only includes just .jsonld but also the .jsons now.

If changes are merged, JSON schema needs to be re-registered with Synapse registry.

This should mostly work -- it is in the propagate.yaml workflow. It is just sending a request to the Synapse server with the new schemas.

Update: adding @cconrad8 mainly for awareness bc asked about this last sprint.

@anngvu anngvu force-pushed the feat/json-schema-workflow branch 2 times, most recently from aa7a613 to ea4ef31 Compare February 22, 2024 23:26
@anngvu anngvu force-pushed the feat/json-schema-workflow branch from ea4ef31 to a3de102 Compare February 22, 2024 23:30
Copy link

github-actions bot commented Feb 22, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate 😄 template link
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu force-pushed the feat/json-schema-workflow branch from e847bf8 to 430aae4 Compare March 1, 2024 21:58
@anngvu anngvu force-pushed the feat/json-schema-workflow branch from 743fca8 to c202b37 Compare March 1, 2024 22:21
@anngvu anngvu marked this pull request as ready for review March 1, 2024 22:42
@anngvu anngvu requested a review from cconrad8 March 1, 2024 22:44
@cconrad8
Copy link
Contributor

cconrad8 commented Mar 5, 2024

Thanks! I will comment on the issue with just one follow-up to help me understand but unrelated to the PR

@anngvu anngvu merged commit 30291f1 into main Mar 7, 2024
@anngvu anngvu deleted the feat/json-schema-workflow branch March 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants