-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/json schema workflow #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anngvu
force-pushed
the
feat/json-schema-workflow
branch
2 times, most recently
from
February 22, 2024 23:26
aa7a613
to
ea4ef31
Compare
anngvu
force-pushed
the
feat/json-schema-workflow
branch
from
February 22, 2024 23:30
ea4ef31
to
a3de102
Compare
Test Suite ReportTemplate Generation
Manifest Validation
|
anngvu
force-pushed
the
feat/json-schema-workflow
branch
from
March 1, 2024 21:58
e847bf8
to
430aae4
Compare
anngvu
force-pushed
the
feat/json-schema-workflow
branch
from
March 1, 2024 22:21
743fca8
to
c202b37
Compare
cconrad8
approved these changes
Mar 5, 2024
Thanks! I will comment on the issue with just one follow-up to help me understand but unrelated to the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements needed changes described in #398.
Previously schemas were re-registered manually after updates, but it would be better to build it into the workflow.
You can see this in how files changed not only includes just
.jsonld
but also the.json
s now.This should mostly work -- it is in the
propagate.yaml
workflow. It is just sending a request to the Synapse server with the new schemas.Update: adding @cconrad8 mainly for awareness bc asked about this last sprint.