Fix case-insensitive bug from schematic upgrade #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cconrad8 encountered this during mtDCA testing and I just realized this.
So before we upgraded to schematic 24.1.1 in #396, enums were capitalization-sensitive, so you could use
DataSubtype
as range and it would be fine because schematic still distinguished the propertydataSubtype
from the valid valuesDataSubtype
. But now anything valid values really needs to be DataSubtypeEnum now.Can see this by comparing templates generated in PR 396 with e.g. ones before, such as PR 393.