Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case-insensitive bug from schematic upgrade #401

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Mar 7, 2024

@cconrad8 encountered this during mtDCA testing and I just realized this.

So before we upgraded to schematic 24.1.1 in #396, enums were capitalization-sensitive, so you could use DataSubtype as range and it would be fine because schematic still distinguished the property dataSubtype from the valid values DataSubtype. But now anything valid values really needs to be DataSubtypeEnum now.

Can see this by comparing templates generated in PR 396 with e.g. ones before, such as PR 393.

@anngvu anngvu requested a review from cconrad8 March 7, 2024 17:21
@anngvu anngvu changed the title Fix capitalization bug from schematic upgrade Fix case-insensitive bug from schematic upgrade Mar 7, 2024
@anngvu anngvu marked this pull request as ready for review March 7, 2024 17:27
Copy link

github-actions bot commented Mar 7, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate 😄 template link
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@cconrad8
Copy link
Contributor

cconrad8 commented Mar 7, 2024

Could you show me a screen shot of where you mean? Having a hard time seeing! Although I believe you!

image

image

@anngvu
Copy link
Collaborator Author

anngvu commented Mar 7, 2024

@cconrad8 It is pretty subtle, that's probably why we missed it!
annotely_image

@anngvu anngvu merged commit c4c750a into main Mar 8, 2024
@anngvu anngvu deleted the patch/datasubtype branch March 8, 2024 16:24
anngvu added a commit that referenced this pull request Mar 8, 2024
@anngvu anngvu mentioned this pull request Mar 8, 2024
anngvu added a commit that referenced this pull request Mar 8, 2024
* Update docs after changes in #401

* Regenerate

* Update CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants