Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/meth array template #408

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Feat/meth array template #408

merged 9 commits into from
Mar 20, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Mar 14, 2024

Close #405. Basically, the current EpigeneticsAssayTemplate assumes bisulfite sequencing, but we do need to add a template for methylation array data for attributes to make more sense, such as having channels, etc. ADKP model has such a template, but we're adapting Genomics Data Common's https://docs.gdc.cancer.gov/Data_Dictionary/viewer/#?view=table-definition-view&id=raw_methylation_array because it is a better standard.

Update: here is an example with metadata filled in (translated from GEO) for Harish Vasudevan dataset.

Copy link

github-actions bot commented Mar 14, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu requested review from allaway and cconrad8 March 18, 2024 18:32
"sms:displayName" : "plateWell",
"sms:required" : "sms:false"
}, {
"@id" : "bts:chipID",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anngvu - isn't this the same as platform? Could we consolidate with that concept (and perhaps also we could specify GEO platform ids for arrays....? :) (

Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made one optional suggestion regarding chipID

@anngvu
Copy link
Collaborator Author

anngvu commented Mar 20, 2024

Thanks @allaway -- GDC actually already had platform as a separate field with the expected enums, so I think chipID is an optional user-specified field intended for batch management.

@anngvu anngvu merged commit 9dd7d7a into main Mar 20, 2024
@anngvu anngvu deleted the feat/meth-array-template branch March 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methylation array assay template
3 participants