-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/meth array template #408
Conversation
Test Suite ReportTemplate Generation
Manifest Validation
|
"sms:displayName" : "plateWell", | ||
"sms:required" : "sms:false" | ||
}, { | ||
"@id" : "bts:chipID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anngvu - isn't this the same as platform
? Could we consolidate with that concept (and perhaps also we could specify GEO platform ids for arrays....? :) (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I made one optional suggestion regarding chipID
Thanks @allaway -- GDC actually already had |
Close #405. Basically, the current EpigeneticsAssayTemplate assumes bisulfite sequencing, but we do need to add a template for methylation array data for attributes to make more sense, such as having channels, etc. ADKP model has such a template, but we're adapting Genomics Data Common's https://docs.gdc.cancer.gov/Data_Dictionary/viewer/#?view=table-definition-view&id=raw_methylation_array because it is a better standard.
Update: here is an example with metadata filled in (translated from GEO) for Harish Vasudevan dataset.