Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parameter.yaml #414

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Update Parameter.yaml #414

merged 2 commits into from
Apr 1, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Apr 1, 2024

https://sagebionetworks.jira.com/browse/NFOSI-774

Edit: tests are failing due to ImportError: cannot import name 'TypeAliasType' from 'typing_extensions', and we haven't changed any versions or testing code since last run #412, so I think this may be an Actions environment issue that may resolve itself or need to be resolved separately.

Copy link

github-actions bot commented Apr 1, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-01 17:51 UTC

Copy link

github-actions bot commented Apr 1, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate
BiospecimenTemplate
ClinicalAssayTemplate
EpigeneticsAssayTemplate
FlowCytometryTemplate
GenomicsAssayTemplate
GenomicsAssayTemplateExtended
HumanCohortTemplate
ImagingAssayTemplate
LightScatteringAssayTemplate
MethylationArrayTemplate
MRIAssayTemplate
PharmacokineticsAssayTemplate
PlateBasedReporterAssayTemplate
ProcessedAlignedReadsTemplate
ProcessedExpressionTemplate
ProcessedVariantCallsTemplate
ProteomicsAssayTemplate
ProtocolTemplate
RNASeqTemplate
ScRNASeqTemplate
UpdateMilestoneReport
WESTemplate
WGSTemplate

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu merged commit 377b9ae into main Apr 1, 2024
@anngvu anngvu deleted the patch/library-prep-kit branch April 1, 2024 17:50
Copy link
Contributor

allaway commented Apr 4, 2024

Interesting, I am also getting this error when I try to run schematic CLI....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants