Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nCounter assay #433

Merged
merged 11 commits into from
Apr 26, 2024
Merged

add nCounter assay #433

merged 11 commits into from
Apr 26, 2024

Conversation

allaway
Copy link
Contributor

@allaway allaway commented Apr 23, 2024

Another stab at closing #428

From #432 - commented out the spatial/geomx template for later, added ncounter assay and added it to the array template.

Copy link

github-actions bot commented Apr 23, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://nf-osi.github.io/nf-metadata-dictionary/pr-preview/pr-433/
on branch gh-pages at 2024-04-23 14:54 UTC

modules/Template/Data.yaml Outdated Show resolved Hide resolved
modules/Template/Data.yaml Outdated Show resolved Hide resolved
@allaway allaway requested a review from anngvu April 23, 2024 14:54
@allaway allaway marked this pull request as ready for review April 23, 2024 14:58
@allaway allaway changed the title Allaway patch 2 add nCounter assay Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate 😄 template link
BiospecimenTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate
ImagingAssayTemplate
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

@anngvu anngvu merged commit 565c330 into main Apr 26, 2024
2 of 3 checks passed
@anngvu anngvu deleted the allaway-patch-2 branch April 26, 2024 15:19
@anngvu anngvu mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants