Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "cellular neurofibroma" #446

Merged
merged 2 commits into from
May 14, 2024
Merged

adding "cellular neurofibroma" #446

merged 2 commits into from
May 14, 2024

Conversation

allaway
Copy link
Contributor

@allaway allaway commented May 10, 2024

One of the the SPORE datasets has one of these types of tumors. I haven't heard of them previously and they don't appear to be mentioned in the literature often or recently, but it's in NCIT. It's possible that this is a variant of or related to some of the other, newer, neurofibroma types.

Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://nf-osi.github.io/nf-metadata-dictionary/pr-preview/pr-446/
on branch gh-pages at 2024-05-10 13:59 UTC

Copy link

Test Suite Report 24.4.1

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_control.csv 😄

@allaway allaway requested a review from anngvu May 10, 2024 15:22
@anngvu anngvu merged commit e872f75 into main May 14, 2024
@anngvu anngvu deleted the allaway-patch-3 branch May 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants