Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at adding props to RNAseqTemplate #502

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

aditya-nath-sage
Copy link
Contributor

Added requested fields to Data.yml in RNASeqTemplate.

Do I need to update any testing resources? Was this the correct Assay to update?

Copy link

github-actions bot commented Aug 20, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-20 21:42 UTC

Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

modules/Template/Data.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also, might want to reset and use more recent updates from main to avoid the conflict.)

Copy link

github-actions bot commented Aug 20, 2024

Test Suite Report 24.7.2

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv

Copy link
Collaborator

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @aditya-nath-sage! Note: the two failing tests are expected due to some schematic issues. Merging.

@anngvu anngvu merged commit a6c3c47 into main Aug 20, 2024
@anngvu anngvu deleted the patch/issues-320 branch August 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to annotate RNAseq files with additional keys for crispr/drug tx
3 participants