Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagnosis and tumorType per #575 #577

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update diagnosis and tumorType per #575 #577

merged 2 commits into from
Feb 12, 2025

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented Feb 7, 2025

Small improvements described in #575. Anyone in @nf-osi/dcc-team who has time can take a quick look.

Copy link

github-actions bot commented Feb 7, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-12 22:49 UTC

Copy link

github-actions bot commented Feb 7, 2025

Test Suite Report 24.7.2

Template Generation

template result link
ChIPSeqTemplate 😄 template link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv 😄
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv

@anngvu anngvu requested review from a team, cconrad8, jaybee84, allaway, aditya-nath-sage and changtotheintothemoon and removed request for a team February 7, 2025 19:04
@anngvu anngvu merged commit b3194e9 into main Feb 12, 2025
@anngvu anngvu deleted the patch-575 branch February 12, 2025 22:48
@anngvu anngvu linked an issue Feb 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/update tumor types and diagnosis
2 participants