Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapser refactor phase a #171

Merged
merged 37 commits into from
Jul 15, 2024
Merged

synapser refactor phase a #171

merged 37 commits into from
Jul 15, 2024

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Feb 23, 2024

Update:

  • Currently, have to be very specific about using synapser (>= 1.0.0) and < 2.0, suggesting you use 1.3.0, see linked issue discussion regarding synSetAnnotations. However, by the time everything is refactored, I trust that synapser will have added back synSetAnnotations.
  • Ignore the one failed MacOS check, I think it is a brew issue upstream that will be resolved eventually, see discussion at setup-r@master 403 error: Failed to download resource "qpdf" r-lib/actions#280
    image
  • Suggest @allaway can review the low-level code, @cconrad8 can be made aware of the new vignettes.

@anngvu anngvu marked this pull request as ready for review February 27, 2024 15:36
@anngvu
Copy link
Contributor Author

anngvu commented Feb 27, 2024

There appears to be a synapser issue that has to be resolved upstream of us. So on Linux stable source build, can use synapser::synSetAnnotations just fine. On MacOs and Windows, one gets the error
Error: 'synSetAnnotations' is not an exported object from 'namespace:synapser'

@allaway
Copy link
Collaborator

allaway commented Feb 28, 2024

@anngvu, should we report this on Sage-Bionetworks/synapser?

@anngvu
Copy link
Contributor Author

anngvu commented Feb 29, 2024

Reported in Sage-Bionetworks/synapser#331. I think for now best solution is to specify synapser (>= 1.0.0) and < 2.0 and update CI workflow.

@anngvu anngvu requested review from allaway and cconrad8 March 4, 2024 22:54
Copy link

github-actions bot commented Mar 12, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://nf-osi.github.io/nfportalutils/pr-preview/pr-171/
on branch gh-pages at 2024-03-13 00:35 UTC

@anngvu
Copy link
Contributor Author

anngvu commented Mar 12, 2024

Update 2:

@anngvu anngvu force-pushed the patch/synapser-phase-a branch from 9f5d032 to 9b87c11 Compare March 13, 2024 00:30
tryCatch({
view <- .syn$tableQuery(glue::glue("SELECT id,type,benefactorId FROM {fileview_id}"))
view <- synapser::synTableQuery(glue::glue("SELECT id,type,benefactorId FROM {fileview_id}")) %>%
synapser::as.data.frame() %>%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually do not need synapser::

@anngvu anngvu changed the base branch from develop to develop-synapser July 15, 2024 15:11
@anngvu
Copy link
Contributor Author

anngvu commented Jul 15, 2024

Merging this into develop-synapser isntead of main develop for now.

@anngvu anngvu merged commit 0ba25ec into develop-synapser Jul 15, 2024
5 of 6 checks passed
@anngvu anngvu linked an issue Jul 25, 2024 that may be closed by this pull request
@anngvu anngvu deleted the patch/synapser-phase-a branch July 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor synapse-adjacent functions to use new reticulate-based synapser Phase A for synapser factor
2 participants