Fixed determining primary attribute key for meta tags #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we write tests as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
primaryAttributeKeyis set to the last item in theprimaryAttributesarray which matches the conditions. If the last property value isnull, the whole meta tag will be discarded.An example:
<meta content={'some-content'} property={'some-value'} name={null} />. HereprimaryAttributeKeywill be set toname(as it is last in the list of properties), and then the meta tag will not be rendered asnameisnull.Proposed solution
To avoid such situations we should consider only properties with non-false values as candidates for
primaryAttributeKey.