Efergy ems #228
Closed
Efergy ems #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have all the commits from #220 as well. You might consider a separate branch for separate proposed changes, unless they're related. |
|
Yes, it has both features. For me this new EMS module does not make sense without the power from the grid limit feature. |
|
It makes it significantly harder for us to review the submission. If this were just a PR for the EMS module I'd be able to merge it on the spot, as EMS modules are entirely isolated and do not affect operation of the software for users not using the EMS module, but it is also a change to the master module and the charging logic which can effectively impact everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new module to get consumption Efergy Engage