Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop leftovers from EOL Python version support #138

Merged
merged 1 commit into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions cs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
import os
import sys
from collections import defaultdict

try:
from configparser import NoSectionError
except ImportError: # python 2
from ConfigParser import NoSectionError
from configparser import NoSectionError

try:
import pygments
Expand All @@ -32,15 +28,14 @@
"CloudStackApiException",
]

if sys.version_info >= (3, 5):
try:
import aiohttp # noqa
except ImportError:
pass
else:
from ._async import AIOCloudStack # noqa
try:
import aiohttp # noqa
except ImportError:
pass
else:
from ._async import AIOCloudStack # noqa

__all__.append("AIOCloudStack")
__all__.append("AIOCloudStack")


def _format_json(data, theme):
Expand Down
48 changes: 11 additions & 37 deletions cs/client.py
Original file line number Diff line number Diff line change
@@ -1,49 +1,25 @@
#! /usr/bin/env python
from __future__ import print_function

import base64
import hashlib
import hmac
import os
import re
import sys
import time
from configparser import ConfigParser
from datetime import datetime, timedelta
from fnmatch import fnmatch

try:
from configparser import ConfigParser
except ImportError: # python 2
from ConfigParser import ConfigParser

try:
from urllib.parse import quote
except ImportError: # python 2
from urllib import quote
from urllib.parse import quote

import pytz

import requests
from requests.structures import CaseInsensitiveDict

PY2 = sys.version_info < (3, 0)

if PY2:
text_type = unicode # noqa
string_type = basestring # noqa
integer_types = int, long # noqa
binary_type = str
else:
text_type = str
string_type = str
integer_types = int
binary_type = bytes

if sys.version_info >= (3, 5):
try:
from . import AIOCloudStack # noqa
except ImportError:
pass
try:
from . import AIOCloudStack # noqa
except ImportError:
pass


TIMEOUT = 10
Expand Down Expand Up @@ -124,8 +100,6 @@ def cs_encode(s):

java.net.URLEncoder.encode(s).replace('+', '%20')
"""
if PY2 and isinstance(s, text_type):
s = s.encode("utf-8")
return quote(s, safe="*")


Expand All @@ -146,11 +120,11 @@ def transform(params):
params.pop(key)
continue

if isinstance(value, (string_type, binary_type)):
if isinstance(value, (str, bytes)):
continue

if isinstance(value, integer_types):
params[key] = text_type(value)
if isinstance(value, int):
params[key] = str(value)
elif isinstance(value, (list, tuple, set, dict)):
if not value:
params.pop(key)
Expand All @@ -166,7 +140,7 @@ def transform(params):
for index, val in enumerate(value):
for name, v in val.items():
k = "%s[%d].%s" % (key, index, name)
params[k] = text_type(v)
params[k] = str(v)
else:
raise ValueError(type(value))

Expand Down Expand Up @@ -606,7 +580,7 @@ def read_config(ini_group=None):
# convert booleans values.
bool_keys = ("dangerous_no_tls_verify",)
for bool_key in bool_keys:
if isinstance(config[bool_key], string_type):
if isinstance(config[bool_key], str):
try:
config[bool_key] = strtobool(config[bool_key])
except ValueError:
Expand Down
12 changes: 2 additions & 10 deletions tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,8 @@
from contextlib import contextmanager
from functools import partial
from unittest import TestCase

try:
from unittest.mock import patch
except ImportError:
from mock import patch

try:
from urllib.parse import urlparse, parse_qs
except ImportError:
from urlparse import urlparse, parse_qs
from unittest.mock import patch
from urllib.parse import urlparse, parse_qs

from cs import (
CloudStack,
Expand Down
Loading