Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine php fpm process status #454

Closed

Conversation

achawla2012
Copy link
Contributor

@achawla2012 achawla2012 commented Aug 25, 2023

Proposed changes

This change determines status of php-fpm (this would be included as part of php-fpm health check).

Testing

Tested via unit/Shell command

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit df53dd9
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ee5671ce4f560008f01e0a

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Aug 25, 2023
@achawla2012 achawla2012 force-pushed the phpfpmmetricsprocessstatusph2 branch from b47af90 to 4a21552 Compare August 28, 2023 05:04
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 72.97% and project coverage change: -0.20% ⚠️

Comparison is base (7c1ada3) 67.19% compared to head (df53dd9) 66.99%.
Report is 4 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   67.19%   66.99%   -0.20%     
==========================================
  Files         113      114       +1     
  Lines       12849    12966     +117     
==========================================
+ Hits         8634     8687      +53     
- Misses       3647     3708      +61     
- Partials      568      571       +3     
Files Changed Coverage Δ
src/core/environment.go 52.03% <ø> (+0.07%) ⬆️
...or/github.com/nginx/agent/sdk/v2/config_helpers.go 64.19% <50.00%> (+0.18%) ⬆️
...rc/extensions/php-fpm-metrics/pkg/phpfpm/status.go 74.28% <74.28%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achawla2012
Copy link
Contributor Author

Closing this as this is ported to #460

@achawla2012 achawla2012 closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants