Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix NGINX install link and dockerfile section #928

Merged
merged 2 commits into from
Nov 13, 2024
Merged

docs: Fix NGINX install link and dockerfile section #928

merged 2 commits into from
Nov 13, 2024

Conversation

Jcahilltorre
Copy link
Contributor

Proposed changes

  • Fixes a link to the wrong guide
  • Removes section referencing dockerfiles that are not available any more

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Jcahilltorre Jcahilltorre self-assigned this Nov 13, 2024
@Jcahilltorre Jcahilltorre requested a review from a team as a code owner November 13, 2024 13:54
@github-actions github-actions bot added bug Something isn't working dependencies documentation Improvements or additions to documentation labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-agent/928/

nginx-seanmoloney
nginx-seanmoloney approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@nginx-seanmoloney nginx-seanmoloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @Jcahilltorre

@Jcahilltorre Jcahilltorre merged commit c44d323 into main Nov 13, 2024
38 checks passed
@Jcahilltorre Jcahilltorre deleted the link-fix branch November 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-seanmoloney nginx-seanmoloney nginx-seanmoloney approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@Jcahilltorre Jcahilltorre

Labels
bug Something isn't working dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jcahilltorre @oliveromahony @nginx-seanmoloney