Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FileOverview to UpdateOverviewResponse #930

Merged
merged 14 commits into from
Dec 17, 2024
Merged

Added FileOverview to UpdateOverviewResponse #930

merged 14 commits into from
Dec 17, 2024

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Nov 13, 2024 •
edited
Loading

Proposed changes

Added FileOverview to respond to the Upload Config. This gives a list of files uploaded successfully in the response back to the management plane, so that the Management Plane can reconcile the data has been uploaded

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@oliveromahony oliveromahony requested a review from a team as a code owner November 13, 2024 17:23
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Nov 13, 2024
@oliveromahony oliveromahony changed the title added the new payload Added FileOverview to UpdateOverviewResponse Nov 13, 2024
@oCHRISo oCHRISo marked this pull request as draft November 14, 2024 10:49
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Nov 20, 2024
@oliveromahony oliveromahony marked this pull request as ready for review December 5, 2024 17:31
yluf5
yluf5 reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@yluf5 yluf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with N1 changes. It is working as expected.

dhurley
dhurley approved these changes Dec 17, 2024
View reviewed changes
internal/file/file_manager_service.go Outdated Show resolved Hide resolved
internal/file/file_manager_service.go Outdated Show resolved Hide resolved
internal/logger/logger.go Outdated Show resolved Hide resolved
@oliveromahony oliveromahony merged commit da6adb1 into v3 Dec 17, 2024
20 checks passed
@oliveromahony oliveromahony deleted the update-overview branch December 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yluf5 yluf5 yluf5 left review comments

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oliveromahony @dhurley @craigell @sean-breen @yluf5 @oCHRISo