Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watcher & resource race conditions #981

Merged
merged 32 commits into from
Feb 19, 2025
Merged

Fix watcher & resource race conditions #981

merged 32 commits into from
Feb 19, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 13, 2025

Proposed changes

Fixed race conditions occurring with the watcher and resource plugins

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Feb 13, 2025
@aphralG aphralG requested a review from a team as a code owner February 13, 2025 17:34
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Feb 13, 2025
dhurley
dhurley reviewed Feb 19, 2025
View reviewed changes
internal/resource/resource_service.go Outdated Show resolved Hide resolved
internal/resource/resource_service.go Outdated Show resolved Hide resolved
@aphralG aphralG requested a review from dhurley February 19, 2025 15:29
@aphralG aphralG merged commit 1bdc156 into v3 Feb 19, 2025
20 checks passed
@aphralG aphralG deleted the fix-watcher-race-condition branch February 19, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

Assignees

@aphralG aphralG

Labels
bug Something isn't working chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @dhurley @craigell @sean-breen