Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoint to product telemetry doc #6855

Merged
merged 2 commits into from
Nov 22, 2024
Merged

add endpoint to product telemetry doc #6855

merged 2 commits into from
Nov 22, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Adds the product telemetry endpoint to the docs oss.edge.df.f5.com

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners November 22, 2024 16:21
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 22, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6855/

ADubhlaoich
ADubhlaoich approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally read my mind: I saw that thread on Slack and wondered if clarifying the exact endpoint in this document would make sense.

@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Nov 22, 2024
@j1m-ryan j1m-ryan merged commit a57f673 into main Nov 22, 2024
30 checks passed
@j1m-ryan j1m-ryan deleted the docs/add-endpoint-product-telemetry-docs branch November 22, 2024 16:43
nginx-bot pushed a commit that referenced this pull request Nov 22, 2024
@j1m-ryan @ADubhlaoich @web-flow
add endpoint to product telemetry doc (#6855)
cbb26fc 
Co-authored-by: Alan Dooley <[email protected]>
j1m-ryan added a commit that referenced this pull request Nov 22, 2024
@nginx-bot @j1m-ryan @ADubhlaoich
[cherry-pick] add endpoint to product telemetry doc (#6856)
d2a7b3d 
add endpoint to product telemetry doc (#6855)

Co-authored-by: Jim Ryan <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j1m-ryan @ADubhlaoich @vepatel @jjngx