-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: set supported Rust version to 1.79.0 #98
Conversation
`cargo fmt` already passes this option, but some editors prefer to call rustfmt directly.
nginx-sys cannot be used as rlib or as a static library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I look at these patches as a part of #97.
the Cargo.toml parsing part looks properly horrible, but I don't really have a better idea how to do it otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I could've replaced it with |
See #96