Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set supported Rust version to 1.79.0 #98

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

bavshin-f5
Copy link
Collaborator

See #96

`cargo fmt` already passes this option, but some editors prefer to call
rustfmt directly.
nginx-sys cannot be used as rlib or as a static library.
@bavshin-f5 bavshin-f5 mentioned this pull request Nov 15, 2024
Copy link

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I look at these patches as a part of #97.

@thresheek
Copy link

the Cargo.toml parsing part looks properly horrible, but I don't really have a better idea how to do it otherwise.

Copy link

@thresheek thresheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bavshin-f5
Copy link
Collaborator Author

the Cargo.toml parsing part looks properly horrible, but I don't really have a better idea how to do it otherwise.

I could've replaced it with sed or cargo metadata | jq. Neither of those look significantly better though :(

@bavshin-f5 bavshin-f5 merged commit 4e833b2 into nginxinc:master Nov 22, 2024
10 checks passed
@bavshin-f5 bavshin-f5 deleted the msrv branch November 22, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants