Upgrade to go1.21 and fix various lints #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runc dependency is unused, we can drop it
Thanks go, good type-system
euank
force-pushed
the
euan/maintainership-update-some-stuff
branch
4 times, most recently
from
8e6b188 to
5a543df
Compare
And also run lints. This is cribbed from the ngrok-go repo
euank
force-pushed
the
euan/maintainership-update-some-stuff
branch
from
5a543df to
9715e16
Compare
andrewryno
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the go version in go.mod and in the (newly added) flake.nix to go1.21.
This also starts running golangci-lint in CI, and does a bunch of other small maintainership things, including addressing golangci-lint errors, and updating some tests to use more concise testing patterns.
This isn't meant to have any functional changes (other than fixing the json struct tag
omitEmpty->omitempty, which should be fine), just update the repo to be a little more modern.